Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update allowed styles with Flow and ESLint #693

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Update allowed styles with Flow and ESLint #693

wants to merge 3 commits into from

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Sep 23, 2024 •
edited
Loading

Update the StyleX Flow types to allow additional valid scrollSnapType values.

Update the ESLint rule to allow containIntrinsic* properties.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

@stylexjs/scripts@0.7.5 size:compare
./size-compare.js /tmp/tmp.cLsanGX44s /tmp/tmp.K898PovGzq

Results Base Patch Ratio
stylex/lib/stylex.js
· compressed 899 899 1.00
· minified 3,223 3,223 1.00
stylex/lib/StyleXSheet.js
· compressed 1,266 1,266 1.00
· minified 3,776 3,776 1.00
rollup-example/.build/bundle.js
· compressed 563,563 563,563 1.00
· minified 10,185,348 10,185,348 1.00
rollup-example/.build/stylex.css
· compressed 100,211 100,211 1.00
· minified 759,868 759,868 1.00

necolas
necolas requested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@necolas necolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires fixes and unit tests please.

packages/eslint-plugin/src/stylex-valid-styles.js Outdated Show resolved Hide resolved
packages/eslint-plugin/src/stylex-valid-styles.js Outdated Show resolved Hide resolved
packages/eslint-plugin/src/stylex-valid-styles.js Outdated Show resolved Hide resolved
packages/stylex/src/StyleXCSSTypes.js Show resolved Hide resolved
packages/stylex/src/StyleXCSSTypes.js Show resolved Hide resolved
@nmn nmn marked this pull request as draft September 23, 2024 20:17
@nmn nmn marked this pull request as ready for review September 23, 2024 23:50
@nmn nmn requested a review from necolas September 23, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@necolas necolas Awaiting requested review from necolas

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmn @necolas @facebook-github-bot